[webkit-reviews] review granted: [Bug 52090] [Soup] ResourceHandleSoup does not ever call didSendData for file uploads : [Attachment 78380] Patch

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 52090: [Soup] ResourceHandleSoup does not ever call didSendData for file
uploads
https://bugs.webkit.org/show_bug.cgi?id=52090

Attachment 78380: Patch
https://bugs.webkit.org/attachment.cgi?id=78380&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=78380&action=review

Looks great!

> WebCore/platform/network/soup/ResourceHandleSoup.cpp:261
> +    ASSERT(buffer);

I'd move this ASSERT up to be the first thing that is done.