[webkit-reviews] review granted: [Bug 53911] Deploy EditingStyle in applyBlockStyle and applyInlineStyle : [Attachment 81464] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 53911: Deploy EditingStyle in applyBlockStyle and applyInlineStyle
https://bugs.webkit.org/show_bug.cgi?id=53911

Attachment 81464: Patch
https://bugs.webkit.org/attachment.cgi?id=81464&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=81464&action=review

> Source/WebCore/ChangeLog:21
> +	   (WebCore::ApplyStyleCommand::removeInlineStyleFromElement): Allows
style to be null; exit early instead.

Is this because of the changes to removeInlineStyle() at
ApplyStyleCommand.cpp:917,921?

> Source/WebCore/editing/ApplyStyleCommand.cpp:895
> +	   style->textDirection(textDirection);

Nit: Do you need to check the return value here?