[webkit-reviews] review granted: [Bug 54080] [GTK] Implement UpdateChunk, ChunkedUpdateDrawingArea/Proxy classes for WebKit2 : [Attachment 81959] Proposed patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Alejandro G. Castro
<alex at igalia.com>'s request for review:
Bug 54080: [GTK] Implement UpdateChunk, ChunkedUpdateDrawingArea/Proxy classes
for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=54080

Attachment 81959: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=81959&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=81959&action=review

Looks good to me! I wouldn't mind Amruth taking another look at it too.

> Source/WebKit2/Shared/gtk/UpdateChunk.cpp:112
> +    return cairo_image_surface_create_for_data(reinterpret_cast<unsigned
char*>(m_sharedMemory->data()),

This should just be a static cast, I think.

> Source/WebKit2/UIProcess/ChunkedUpdateDrawingAreaProxy.h:106
> +    // BackingStore

Please remove this comment.