[webkit-reviews] review granted: [Bug 54186] SVGFESpecularLightingElement doesn't support dynamic invalidation, when attributes change. : [Attachment 81944] Patch

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has granted Renata Hodovan <reni at webkit.org>'s
request for review:
Bug 54186: SVGFESpecularLightingElement doesn't support dynamic invalidation,
when attributes change.
https://bugs.webkit.org/show_bug.cgi?id=54186

Attachment 81944: Patch
https://bugs.webkit.org/attachment.cgi?id=81944&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=81944&action=review

r=me but with changes.

>
LayoutTests/svg/dynamic-updates/script-tests/SVGFESpecularLightingElement-dom-i
n-attr.js:12
> +specularElement.setAttribute("in", "BackgroundImage");

Why do you use backgroundImage here? We don't support it at the moment! Can you
use SourceAlpha instead? Otherwise it could be confusing to compare the test on
a manual run between browsers.

>
LayoutTests/svg/dynamic-updates/script-tests/SVGFESpecularLightingElement-svgdo
m-in-prop.js:12
> +specularElement.setAttribute("in", "BackgroundImage");

Ditto.