[webkit-reviews] review granted: [Bug 54118] XMLHttpRequest::abort() doesn't clear response data : [Attachment 81913] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 10 00:06:20 PST 2011


Alexey Proskuryakov <ap at webkit.org> has granted Jarred Nicholls
<jarred.nicholls at gmail.com>'s request for review:
Bug 54118: XMLHttpRequest::abort() doesn't clear response data
https://bugs.webkit.org/show_bug.cgi?id=54118

Attachment 81913: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=81913&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
Thanks for testing! I'd be fine with following the spec then, and just going
with your original patch here (plus a regression test).

The new function name is not so great, because it's not just buffers that are
cleared. I'm going to say r+ with hope that this function will go away very
soon.


More information about the webkit-reviews mailing list