[webkit-reviews] review granted: [Bug 54164] Optimize global_var accesses on JSVALUE64 : [Attachment 81917] The patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Gavin Barraclough
<barraclough at apple.com>'s request for review:
Bug 54164: Optimize global_var accesses on JSVALUE64
https://bugs.webkit.org/show_bug.cgi?id=54164

Attachment 81917: The patch
https://bugs.webkit.org/attachment.cgi?id=81917&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=81917&action=review

> Source/JavaScriptCore/ChangeLog:7
> +	   Directly embed the pointer to d->registers, ptimize out the load

ptimize -> optimize.  I am glad to see you are even optimizing spelling!

> Source/JavaScriptCore/ChangeLog:10
> +	   This is a ~1.5% win on sunspidey.

Wow, nice.