[webkit-reviews] review granted: [Bug 54154] File uploads do not work within the sandbox : [Attachment 81895] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Sam Weinig <sam at webkit.org>'s request
for review:
Bug 54154: File uploads do not work within the sandbox
https://bugs.webkit.org/show_bug.cgi?id=54154

Attachment 81895: Patch
https://bugs.webkit.org/attachment.cgi?id=81895&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=81895&action=review

> Source/WebKit2/UIProcess/WebPageProxy.cpp:2124
> +	   SandboxExtension::Handle sandboxExtensionHandle;
> +	   SandboxExtension::createHandle(fileURLs[i],
SandboxExtension::ReadOnly, sandboxExtensionHandle);

Why does this use an out argument instead of a return value?

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1561
> +    RefPtr<SandboxExtension> extension = SandboxExtension::create(handle);
> +    extension->consumePermanently();

No need for a local variable here.