[webkit-reviews] review granted: [Bug 54103] Implement fast path for matching simple selectors : [Attachment 81885] patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 54103: Implement fast path for matching simple selectors
https://bugs.webkit.org/show_bug.cgi?id=54103

Attachment 81885: patch
https://bugs.webkit.org/attachment.cgi?id=81885&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=81885&action=review

> Source/WebCore/css/CSSStyleSelector.cpp:365
> +    bool canFastCheckSelector() const { return m_canFastCheckSelector; }
> +    bool hasMultipartSelector() const { return m_hasMultipartSelector; }
> +    bool topHTMLSelectorMatchesBasedOnRuleHash() const { return
m_topHTMLSelectorMatchesBasedOnRuleHash; }

When possible I prefer booleans that read like sentences “rule data <xxx>”. The
first and third names here don’t really work that way.