[webkit-reviews] review denied: [Bug 54118] XMLHttpRequest::abort() should call clearResponse() : [Attachment 81836] Proposed patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied	review:
Bug 54118: XMLHttpRequest::abort() should call clearResponse()
https://bugs.webkit.org/show_bug.cgi?id=54118

Attachment 81836: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=81836&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
Thanks, that's convincing. I only picked one example, for a case where I could
quickly tell that there is a behavior change. Can you go over uses of
m_response in the file and check that it is always expected to have null
response after abort()?

> We are actually fixing two things at once here...

I think that this needs a regression test then. Please add one (setting r- to
that effect). It would be nice to know if the test passes in both IE and
Firefox.