[webkit-reviews] review denied: [Bug 53510] [chromium] [WebCore] [android] Touch events are missing time stamps : [Attachment 80785] p1 for 53510

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 9 15:17:37 PST 2011


Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Robert Kroeger
<rjkroege at chromium.org>'s request for review:
Bug 53510: [chromium] [WebCore] [android] Touch events are missing time stamps
https://bugs.webkit.org/show_bug.cgi?id=53510

Attachment 80785: p1 for 53510
https://bugs.webkit.org/attachment.cgi?id=80785&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=80785&action=review

> Source/WebKit/chromium/public/WebTouchPoint.h:41
> +    enum TouchIdentifier {

nit: style for enums in WebKit API headers is like this:

enum Foo {
    FooBar,
    FooBaf,
    FooBah
};

so, this could be:

enum Finger {
    FingerFirst,
    FingerSecond,
    FingerThird
};


More information about the webkit-reviews mailing list