[webkit-reviews] review granted: [Bug 52877] Detach Geolocation from Frame when Page destroyed. : [Attachment 80316] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted John Knottenbelt
<jknotten at chromium.org>'s request for review:
Bug 52877: Detach Geolocation from Frame when Page destroyed.
https://bugs.webkit.org/show_bug.cgi?id=52877

Attachment 80316: Patch
https://bugs.webkit.org/attachment.cgi?id=80316&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=80316&action=review

Ok.  This whole design seems fragile.  We need some kind of real weak pointer.

>
LayoutTests/fast/dom/Geolocation/resources/page-reload-cancel-permission-reques
ts-inner.html:6
> +	     /* navigator.geolocation.getCurrentPosition(function() {}); */

Please remove commented out code.