[webkit-reviews] review granted: [Bug 52712] Add a compile-time option to disable WebArchive support : [Attachment 80633] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Jeremy Moskovich
<playmobil at google.com>'s request for review:
Bug 52712: Add a compile-time option to disable WebArchive support
https://bugs.webkit.org/show_bug.cgi?id=52712

Attachment 80633: Patch
https://bugs.webkit.org/attachment.cgi?id=80633&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=80633&action=review

This looks good to me, but I'm not a WebArchive expert.  I've been avoiding
reviewing this patch because folks pointed out errors in my previous review. 
However, no one else seems to be reviewing this patch...  Maybe give folks some
time to take another look before landing?

> Source/WebCore/ChangeLog:15
> +	       WebArchive support is currently enabled for all ports that
define PLATFORM(CF) apart from QT.

QT => Qt

> Source/WebCore/WebCore.gyp/WebCore.gyp:1348
> +	   # Don't build files needed for WebArchive support. Since we disable
> +	   # this feature.

The second sentence here isn't a complete sentence.