[webkit-reviews] review granted: [Bug 54074] nrwt multiprocessing: add in per-worker, per-shard stats : [Attachment 81764] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 54074: nrwt multiprocessing: add in per-worker, per-shard stats
https://bugs.webkit.org/show_bug.cgi?id=54074

Attachment 81764: Patch
https://bugs.webkit.org/attachment.cgi?id=81764&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=81764&action=review

Just a couple minor things.

> Tools/Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:157
> +	   thread_timings = [w.stats for w in self._workers.values()]

s/w/worker

> Tools/Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:218
> +    def _update_worker_stats(self, src, result, elapsed_time):

You don't use result here.