[webkit-reviews] review granted: [Bug 54102] IndexedDB: Update the semantics of put() : [Attachment 81811] Patch

[bugzilla-daemon at webkit.org]

Jeremy Orlow <jorlow at chromium.org> has granted Hans Wennborg
<hans at chromium.org>'s request for review:
Bug 54102: IndexedDB: Update the semantics of put()
https://bugs.webkit.org/show_bug.cgi?id=54102

Attachment 81811: Patch
https://bugs.webkit.org/attachment.cgi?id=81811&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=81811&action=review

r=me

> Source/WebCore/storage/IDBObjectStoreBackendImpl.cpp:229
> +	   // FIXME: Generate auto increment key, and inject it through the key
path.

Can you do this in a follow up patch?

> Source/WebCore/storage/IDBObjectStoreBackendImpl.cpp:260
> +    RefPtr<SerializedScriptValue> value = prpValue;

The only time we need to do the whole prp and then save it to a RefPtr bit is
when we pass the PassRefPtr to something that takes a PassRefPtr.  If we're
just doing ->'s and .get()s then we don't actually need to do it.  Not sure if
you do here, but just something to note.  (We use it more than we probably
should.)

Does stuff below reference prpValue or value?  If it's the former, then you
have a bug.