[webkit-reviews] review requested: [Bug 54117] Replace static_cast<HTMLElement*> with toHTMLElement : [Attachment 81851] Patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 9 12:24:12 PST 2011


Yael <yael.aharon at nokia.com> has asked	for review:
Bug 54117: Replace static_cast<HTMLElement*> with toHTMLElement
https://bugs.webkit.org/show_bug.cgi?id=54117

Attachment 81851: Patch.
https://bugs.webkit.org/attachment.cgi?id=81851&action=review

------- Additional Comments from Yael <yael.aharon at nokia.com>
Only one test hit the ASSERT. It is
editing/execCommand/insert-list-nested-with-orphaned.html .
This test is really expecting the function enclosingListChild to return a node
which is not an HTMLElement.
(The test fails if I skip nodes that are not HTMLElements.)
Once I modified enclosingListChild to return Node and not HTMLElement, all
tests are passing. I updated the patch to  return a Node from
enclosingListChild.


More information about the webkit-reviews mailing list