[webkit-reviews] review granted: [Bug 54067] nrwt multiprocessing: minor cleanup prior to implementing the new worker : [Attachment 81754] make ManagerConnection inherit from BrokerConnection

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 54067: nrwt multiprocessing: minor cleanup prior to implementing the new
worker
https://bugs.webkit.org/show_bug.cgi?id=54067

Attachment 81754: make ManagerConnection inherit from BrokerConnection
https://bugs.webkit.org/attachment.cgi?id=81754&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=81754&action=review

>
Tools/Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:139

> +class _ManagerConnection(message_broker2.BrokerConnection):

It might be good to somehow make it clear in the diagram in message_broker2.py
that BrokerConnection is always a Manager.   Something like:

50	    BrokerClient   ------>    ManagerConnection (implements
BrokerConnection)
51		 ^			   |
52		 |			   v
53		 \----------------	Broker