[webkit-reviews] review denied: [Bug 54118] XMLHttpRequest::abort() should call clearResponse() : [Attachment 81831] Proposed patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Jarred Nicholls
<jarred.nicholls at gmail.com>'s request for review:
Bug 54118: XMLHttpRequest::abort() should call clearResponse()
https://bugs.webkit.org/show_bug.cgi?id=54118

Attachment 81831: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=81831&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=81831&action=review

> Source/WebCore/ChangeLog:6
> +	   XMLHttpRequest::abort() should call clearResponse()
> +	   https://bugs.webkit.org/show_bug.cgi?id=54118

This change log entry is not sufficient. It doesn’t state why this is a good
change. As you do in your bug, but more briefly, you need to state the benefit
of the change: Less memory used after an abort(), presumably.

> Source/WebCore/ChangeLog:8
> +	   No new tests. (OOPS!)

We can’t land a patch with a line like this. You need to change this line into
an explanation of why it’s OK to make this change without adding any new tests.