[webkit-reviews] review granted: [Bug 54053] REGRESSION(r76107): Crash in VisibleSelection::toNormalizedRange : [Attachment 81767] fixes the bug

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 9 09:45:12 PST 2011


Darin Adler <darin at apple.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 54053: REGRESSION(r76107): Crash in VisibleSelection::toNormalizedRange
https://bugs.webkit.org/show_bug.cgi?id=54053

Attachment 81767: fixes the bug
https://bugs.webkit.org/attachment.cgi?id=81767&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=81767&action=review

> Source/WebCore/rendering/RenderFileUploadControl.h:46
> +    VisiblePosition positionForPoint(const IntPoint&);

Better to make this function private. Also, we normally specify virtual
explicitly when overriding a virtual function.


More information about the webkit-reviews mailing list