[webkit-reviews] review denied: [Bug 53916] [Qt] WebKit patches required to work with a modularized version of Qt : [Attachment 81474] Avoided-UiTools-dependency-if-the-module-is-not-present

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 8 19:42:29 PST 2011


Laszlo Gombos <laszlo.1.gombos at nokia.com> has denied Kristian Amlie
<kristian.amlie at nokia.com>'s request for review:
Bug 53916: [Qt] WebKit patches required to work with a modularized version of
Qt
https://bugs.webkit.org/show_bug.cgi?id=53916

Attachment 81474: Avoided-UiTools-dependency-if-the-module-is-not-present
https://bugs.webkit.org/attachment.cgi?id=81474&action=review

------- Additional Comments from Laszlo Gombos <laszlo.1.gombos at nokia.com>
These tools build without UiTools. There is a mechanism to control the UiTools
dependency in WebKit.pri.

Would the following work ? 

-disable_uitools: DEFINES *= QT_NO_UITOOLS
+contains(QT_CONFIG, modular):!contains(QT_CONFIG, uitools)|disable_uitools:
DEFINES *= QT_NO_UITOOLS


More information about the webkit-reviews mailing list