[webkit-reviews] review requested: [Bug 52128] ISO-8859-8 Hebrew text displayed reversed with dir="rtl" : [Attachment 81727] patch w/ layout test

[bugzilla-daemon at webkit.org]

Xiaomei Ji <xji at chromium.org> has asked  for review:
Bug 52128: ISO-8859-8 Hebrew text displayed reversed with dir="rtl"
https://bugs.webkit.org/show_bug.cgi?id=52128

Attachment 81727: patch w/ layout test
https://bugs.webkit.org/attachment.cgi?id=81727&action=review

------- Additional Comments from Xiaomei Ji <xji at chromium.org>
Thanks for the review!
Updated patch per feedback.

The 2nd part of the diff (about reordering runs) inside void
BidiResolver<Iterator, Run>::createBidiRunsForLine() is format change (decrease
indent) due to the removal of condition "if (!visualOrder)".

I tested the bidi resolver part for lines with visual ordering using
https://service.isracard.co.il/templates/isracardEntry/contactus.jsp and
http://berry.co.il/disco/chalordeluna/playme.php
they works correctly.

Dan, Jeremy, if you have more real webpage that uses iso-8859-8, please pass
them to me for test.