[webkit-reviews] review denied: [Bug 54045] Fix scaling and thread safety of FFTFrameFFTW : [Attachment 81714] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 8 17:01:37 PST 2011


Kenneth Russell <kbr at google.com> has denied Chris Rogers <crogers at google.com>'s
request for review:
Bug 54045: Fix scaling and thread safety of FFTFrameFFTW
https://bugs.webkit.org/show_bug.cgi?id=54045

Attachment 81714: Patch
https://bugs.webkit.org/attachment.cgi?id=81714&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
This mostly looks good -- thanks for fixing my bugs -- but as we discussed
offline we should add a static initialize() method to FFTFrame to allow the
mutex to be created from a known good place, before multithreaded allocation of
FFTFrames might start.


More information about the webkit-reviews mailing list