[webkit-reviews] review denied: [Bug 53390] Files missing ENABLE_VIDEO #ifdef : [Attachment 80642] wrap HTMLVideoElement references with ENABLE_VIDEO ifdef in WebGLRenderingContext
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Feb 8 16:41:11 PST 2011
Patrick R. Gansterer <paroga at paroga.com> has denied Andrew Wason
<rectalogic at rectalogic.com>'s request for review:
Bug 53390: Files missing ENABLE_VIDEO #ifdef
https://bugs.webkit.org/show_bug.cgi?id=53390
Attachment 80642: wrap HTMLVideoElement references with ENABLE_VIDEO ifdef in
WebGLRenderingContext
https://bugs.webkit.org/attachment.cgi?id=80642&action=review
------- Additional Comments from Patrick R. Gansterer <paroga at paroga.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=80642&action=review
> Source/WebCore/html/canvas/WebGLRenderingContext.cpp:2990
> +#if defined(ENABLE_VIDEO) && ENABLE_VIDEO
Please use the ENABLE macro in non-idl files. This should be written as
ENABLE(VIDEO).
More information about the webkit-reviews
mailing list