[webkit-reviews] review granted: [Bug 53975] Events should propagate through IDBDatabase (for IDBRequest and IDBTransaction) : [Attachment 81708] Patch

[bugzilla-daemon at webkit.org]

Nate Chapin <japhet at chromium.org> has granted Jeremy Orlow
<jorlow at chromium.org>'s request for review:
Bug 53975: Events should propagate through IDBDatabase (for IDBRequest and
IDBTransaction)
https://bugs.webkit.org/show_bug.cgi?id=53975

Attachment 81708: Patch
https://bugs.webkit.org/attachment.cgi?id=81708&action=review

------- Additional Comments from Nate Chapin <japhet at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=81708&action=review

> Source/WebCore/storage/IDBDatabase.cpp:143
> +ScriptExecutionContext* IDBDatabase::scriptExecutionContext() const
> +{
> +    return ActiveDOMObject::scriptExecutionContext();
> +}

Is there a reason we're overriding this if we're just calling straight to
ActiveDOMObject?

> Source/WebCore/storage/IDBRequest.cpp:150
> +	   // If there ever are events that are associated with a database but
not have a

Grammar nit: "but not have" -> "but do not have"

> Source/WebCore/storage/IDBTransaction.cpp:116
> +ScriptExecutionContext* IDBTransaction::scriptExecutionContext() const
> +{
> +    return ActiveDOMObject::scriptExecutionContext();
> +}
> +

Same as above: is there a reason for this?  Am I missing something obvious?