[webkit-reviews] review granted: [Bug 41187] REGRESSION(HTML 5): HTMLDocumentParser does not report html parse errors to the console : [Attachment 81603] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 41187: REGRESSION(HTML 5): HTMLDocumentParser does not report html parse
errors to the console
https://bugs.webkit.org/show_bug.cgi?id=41187

Attachment 81603: Patch
https://bugs.webkit.org/attachment.cgi?id=81603&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=81603&action=review

This is obviously very primitive.

I'm OK with approving this patch, but we absolutely need testing.  The whole
reason why this support got removed during the re-write is that whoever added
the original error messages added *no* testing.  Thus although we knew we were
removing it, it was never a critical issue and only ever got really noticed 9
months after its removal!

Please file a bug about testing this and link to it from the ChangeLog.

Looks like this might break Chromium too. Not sure why.

> Source/WebCore/ChangeLog:11
> +	   * html/parser/HTMLDocumentParser.h:

Would be nice to mention here what you're doing (moving private to public)
since you can't easily see that from the diff.

> Source/WebCore/html/parser/HTMLTreeBuilder.cpp:2810
> +void HTMLTreeBuilder::parseError(AtomicHTMLToken&)

Why not use the line/column information from the Token?