[webkit-reviews] review granted: [Bug 54028] http/tests/media should be served over HTTP (not from local file) : [Attachment 81706] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Anna Cavender
<annacc at chromium.org>'s request for review:
Bug 54028: http/tests/media should be served over HTTP (not from local file)
https://bugs.webkit.org/show_bug.cgi?id=54028

Attachment 81706: Patch
https://bugs.webkit.org/attachment.cgi?id=81706&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=81706&action=review

I would definitely babysit the bots when this lands, it may break tests that
don't run on the port(s) you tested.

> Tools/Scripts/webkitpy/layout_tests/port/base.py:360
>	   # TODO(dpranke): remove the media reference and the SSL reference?
> -	   if (port and not relative_path.startswith("local/") and
> -	       not relative_path.startswith("media/")):
> +	   if (port and not relative_path.startswith("local/")):

Can this TODO be changed now?