[webkit-reviews] review granted: [Bug 50115] Please implement async=false for dynamic script loading (REGRESSION: LABjs is broken) : [Attachment 81682] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted James Simonsen
<simonjam at chromium.org>'s request for review:
Bug 50115: Please implement async=false for dynamic script loading (REGRESSION:
LABjs is broken)
https://bugs.webkit.org/show_bug.cgi?id=50115

Attachment 81682: Patch
https://bugs.webkit.org/attachment.cgi?id=81682&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=81682&action=review

Looks great!  Ideally Tonyg would look at this patch as well.  Thanks!

> Source/WebCore/dom/ScriptRunner.cpp:68
> +    ASSERT_ARG(scriptElement, scriptElement);

Why ASSERT_ARG and not just ASSERT?