[webkit-reviews] review granted: [Bug 53071] [NRWT] Pull up a rebaseline feature into a single_test_runner out of each test_type. : [Attachment 81606] pull-up-rebaseline

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Hayato Ito <hayato at chromium.org>'s
request for review:
Bug 53071: [NRWT] Pull up a rebaseline feature into a single_test_runner out of
each test_type.
https://bugs.webkit.org/show_bug.cgi?id=53071

Attachment 81606: pull-up-rebaseline
https://bugs.webkit.org/attachment.cgi?id=81606&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=81606&action=review

> Tools/ChangeLog:10
> +	   This patch is a first step for eliminating test_type/* classes.
> +
> +	   https://bugs.webkit.org/show_bug.cgi?id=53071

Is this covered by existing unit tests?  If not, it would be nice to add some
(either in this patch or a follow up patch).

> Tools/Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:111
> +	       self._save_baseline_data(driver_output.image_hash, ".checksum",
> +					encoding="ascii",
> +				       
generate_new_baseline=self._options.new_baseline)

In a separate patch, we could just get rid of the encoding flag.  If we encode
the .checksum files as binary, it should be the same as ascii.