[webkit-reviews] review denied: [Bug 53477] nrwt multiprocessing: add stubs for manager/worker : [Attachment 81586] fix diff baseline

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has denied Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 53477: nrwt multiprocessing: add stubs for manager/worker
https://bugs.webkit.org/show_bug.cgi?id=53477

Attachment 81586: fix diff baseline
https://bugs.webkit.org/attachment.cgi?id=81586&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=81586&action=review

>
Tools/Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:53
> +    _Multiprocessing_Process = multiprocessing.Process

This doesn't appear to be used anywhere.

>
Tools/Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:105

> +    elif worker_model == 'processes' and multiprocessing:
> +	   queue_class = _Multiprocessing_Queue

This appears to be the only use of _Multiprocessing_Queue and it's behind a
multiprocessing check.	Can this just be multiprocessing.Queue and remove the
variable?

>
Tools/Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unitte
st.py:35
> +    _multiprocessing_is_available = True

import multiprocessing

>
Tools/Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unitte
st.py:36
> +    from multiprocessing import Queue as _Multiprocessing_Queue

Not used?

>
Tools/Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unitte
st.py:38
> +    _multiprocessing_is_available = False

multiprocessing = None

>
Tools/Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unitte
st.py:39
> +    _Multiprocessing_Queue = Queue.Queue

Not used?

>
Tools/Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unitte
st.py:74
> +	   if _multiprocessing_is_available:

if multiprocessing: