[webkit-reviews] review granted: [Bug 53158] nrwt multiprocessing: add simplified message broker for new-style messaging : [Attachment 81582] update w/ review feedback from mihaip

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 8 10:29:04 PST 2011


Tony Chang <tony at chromium.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 53158: nrwt multiprocessing: add simplified message broker for new-style
messaging
https://bugs.webkit.org/show_bug.cgi?id=53158

Attachment 81582: update w/ review feedback from mihaip
https://bugs.webkit.org/attachment.cgi?id=81582&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=81582&action=review

> Tools/Scripts/webkitpy/layout_tests/layout_package/message_broker2.py:53
> +    BrokerClient   ------>	 BrokerConnection
> +			  <	      |
> +			   \	      v
> +				   Broker

This might be clearer:
    BrokerClient   ------>    BrokerConnection
	   ^			   |
	   |			   v
	   \----------------	Broker

> Tools/Scripts/webkitpy/layout_tests/layout_package/message_broker2.py:59
> +

Nit: Remove blank line


More information about the webkit-reviews mailing list