[webkit-reviews] review granted: [Bug 54016] Pagination broken on Windows : [Attachment 81656] Patch

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has granted Dave Hyatt
<hyatt at apple.com>'s request for review:
Bug 54016: Pagination broken on Windows
https://bugs.webkit.org/show_bug.cgi?id=54016

Attachment 81656: Patch
https://bugs.webkit.org/attachment.cgi?id=81656&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=81656&action=review

> Source/WebKit/win/WebFrame.cpp:2004
> +	   int paperWidth = printerRect(printDC).width() * desiredPixelsPerInch
/ paperHorizontalPixelsPerInch;
> +	   int paperVerticalPixelsPerInch = ::GetDeviceCaps(printDC,
LOGPIXELSY);
> +	   int paperHeight = printerRect(printDC).height() *
desiredPixelsPerInch / paperVerticalPixelsPerInch;

It would be better to call printerRect once and save the result in a local
variable.