[webkit-reviews] review requested: [Bug 53995] editing/selection/end-of-document.html is failing in the GTK 64-bit debug bot : [Attachment 81649] Patch proposal

Tue Feb 8 09:20:55 PST 2011

Mario Sanchez Prada <msanchez at igalia.com> has asked  for review:
Bug 53995: editing/selection/end-of-document.html is failing in the GTK 64-bit
debug bot
https://bugs.webkit.org/show_bug.cgi?id=53995

Attachment 81649: Patch proposal
https://bugs.webkit.org/attachment.cgi?id=81649&action=review

------- Additional Comments from Mario Sanchez Prada <msanchez at igalia.com>
Ok, it started to fail again for builds 19094, 19095 and 19096, seems it's
flaky after all, hence skipping it for the gtk platform.

IMHO, it could be a timing issue, due to trying to execute the editing commands
too early in the test:

    [...]
    <script>
    function editingTest() {
	selectAllCommand();
	moveSelectionForwardByCharacterCommand();
	moveSelectionBackwardByLineCommand();
    }
    </script>

    <body>

    [...]

    <script>
    runEditingTest();
    </script>

Perhaps just calling to runEditingTest() in body.onload event could help fixing
this.

Attaching patch with that little change.