[webkit-reviews] review granted: [Bug 53883] [WIN] Add missing includes and forward declarations for CFNetwork : [Attachment 81430] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 8 06:55:48 PST 2011


Adam Roben (aroben) <aroben at apple.com> has granted Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 53883: [WIN] Add missing includes and forward declarations for CFNetwork
https://bugs.webkit.org/show_bug.cgi?id=53883

Attachment 81430: Patch
https://bugs.webkit.org/attachment.cgi?id=81430&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=81430&action=review

> Source/WebCore/platform/network/cf/DNSCFNet.cpp:39
>  #if PLATFORM(WIN)
>  #include "LoaderRunLoopCF.h"
> +#include <CFNetwork/CFNetwork.h>

Why only do this for PLATFORM(WIN)?

> Source/WebCore/platform/network/cf/ProxyServerCFNet.cpp:34
> +#if PLATFORM(WIN)
> +#include <CFNetwork/CFNetwork.h>
> +#endif

Why only do this for PLATFORM(WIN)?

> Source/WebCore/platform/network/cf/SocketStreamHandleCFNet.cpp:50
>  #if PLATFORM(WIN)
>  #include "LoaderRunLoopCF.h"
> +#include <CFNetwork/CFNetwork.h>

Why only do this for PLATFORM(WIN)?


More information about the webkit-reviews mailing list