[webkit-reviews] review requested: [Bug 53169] Web Inspector: move InspectorController's methods from InspectorAgent to InspectorController : [Attachment 81629] [patch] fourth version

[bugzilla-daemon at webkit.org]

Ilya Tikhonovsky <loislo at chromium.org> has asked  for review:
Bug 53169: Web Inspector: move InspectorController's methods from
InspectorAgent to InspectorController
https://bugs.webkit.org/show_bug.cgi?id=53169

Attachment 81629: [patch] fourth version
https://bugs.webkit.org/attachment.cgi?id=81629&action=review

------- Additional Comments from Ilya Tikhonovsky <loislo at chromium.org>
(In reply to comment #13)
> (From update of attachment 81617 [details])
> View in context:
https://bugs.webkit.org/attachment.cgi?id=81617&action=review
> 
> > Source/WebCore/inspector/InspectorAgent.cpp:295
> > +void InspectorAgent::didClearWindowObjectInWorld(Frame* frame)
> 
> This method should be renamed since it doesn't accept any world anymore.

done


> > Source/WebCore/inspector/InspectorAgent.cpp:454
> > +	 if (!m_requiredPanel) {
> 
> !m_requiredPanel -> m_requiredPanel

done

> > Source/WebCore/loader/FrameLoader.cpp:2984
> > +	 m_frame->page()->inspectorController()->resume();
> 
> Why has the main frame check gone?

done