[webkit-reviews] review requested: [Bug 53169] Web Inspector: move InspectorController's methods from InspectorAgent to InspectorController : [Attachment 81617] [patch] third version version

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 8 02:31:45 PST 2011


Ilya Tikhonovsky <loislo at chromium.org> has asked  for review:
Bug 53169: Web Inspector: move InspectorController's methods from
InspectorAgent to InspectorController
https://bugs.webkit.org/show_bug.cgi?id=53169

Attachment 81617: [patch] third version version
https://bugs.webkit.org/attachment.cgi?id=81617&action=review

------- Additional Comments from Ilya Tikhonovsky <loislo at chromium.org>
(In reply to comment #7)
> (From update of attachment 80927 [details])
> View in context:
https://bugs.webkit.org/attachment.cgi?id=80927&action=review
> 
> > Source/WebCore/inspector/InspectorAgent.cpp:-161
> > -	 ASSERT(!m_highlightedNode);
> 
> Please revert this line.
done


> > Source/WebCore/inspector/InspectorAgent.cpp:189
> > +	     m_inspectorController->connectFrontend();
> 
> InspectorAgent shouldn't know about InspectorController. You can break this
dependency in a separate change though. Please file a bug and add a FIXME.

done

> > Source/WebCore/inspector/InspectorAgent.cpp:289
> > +	     m_inspectorController->inspect(node.get());
> 
> You shouldn't go into IC here.

done


More information about the webkit-reviews mailing list