[webkit-reviews] review requested: [Bug 38095] webkit should implement -moz-any selector (as -webkit-any obviously) : [Attachment 81611] patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 8 01:04:02 PST 2011


Rémi Zara <remi_zara at mac.com> has asked  for review:
Bug 38095: webkit should implement -moz-any selector (as -webkit-any obviously)
https://bugs.webkit.org/show_bug.cgi?id=38095

Attachment 81611: patch v1
https://bugs.webkit.org/attachment.cgi?id=81611&action=review

------- Additional Comments from Rémi Zara <remi_zara at mac.com>
Here is a patch. Specificity is handled as gecko (that of a pseudo class), and
should be fixed in a followup bug.
No other selectors removed or rules changed in .css files.

Had to move the inline CSSSelectorList::next() to the .cpp file to handle the
introduced dependency of CSSSelector on CSSSelectorList. Not sure that's
right...

Finally, I had trouble testing for :hover. It works when manually testing
though. Pointers welcome for that.


More information about the webkit-reviews mailing list