[webkit-reviews] review granted: [Bug 53977] stop generating results.json files : [Attachment 81587] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 7 22:47:48 PST 2011


Mihai Parparita <mihaip at chromium.org> has granted Ojan Vafai
<ojan at chromium.org>'s request for review:
Bug 53977: stop generating results.json files
https://bugs.webkit.org/show_bug.cgi?id=53977

Attachment 81587: Patch
https://bugs.webkit.org/attachment.cgi?id=81587&action=review

------- Additional Comments from Mihai Parparita <mihaip at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=81587&action=review

>
Tools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:17
2
>      def generate_json_output(self):

Seems like there should be a round of renaming (since these method names are
very generic, and we're going to want more JSON generation code for the
results.html replacement), but that can be done separately later (curious to
see if anything breaks because of this change).


More information about the webkit-reviews mailing list