[webkit-reviews] review denied: [Bug 50661] Convert <meter> shadow DOM to a DOM-based shadow. : [Attachment 81576] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 7 21:13:55 PST 2011


Kent Tamura <tkent at chromium.org> has denied MORITA Hajime
<morrita at google.com>'s request for review:
Bug 50661: Convert <meter> shadow DOM to a DOM-based shadow.
https://bugs.webkit.org/show_bug.cgi?id=50661

Attachment 81576: Patch
https://bugs.webkit.org/attachment.cgi?id=81576&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=81576&action=review

Some drive-by comments.

> Source/WebCore/ChangeLog:22
> +	   Need a short description and bug URL (OOPS!)

oops!

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:22454
> +				0F3DD45012F5EA1B000D9190 /* ShadowBlur.h in
Headers */,
> +				BCE4413412F748E2009B84B8 /* RenderCombineText.h
in Headers */,
> +				BCE4413612F7490B009B84B8 /* FontWidthVariant.h
in Headers */,
> +				14947FFE12F80CD200A0F631 /*
DocumentOrderedMap.h in Headers */,
> +				97C471DC12F925BD0086354B /*
ContentSecurityPolicy.h in Headers */,
> +				A7FE819C12FA677700850C1E /*
ProgressBarValueElement.h in Headers */,

Do you want to add these files?

> Source/WebCore/html/shadow/MeterPartElement.h:53
> +    MeterPartElement(Document* document, PartType type) 

This should be private.

> Source/WebCore/html/shadow/MeterPartElement.h:76
> +inline const AtomicString* MeterPartElement::computeShadowPseudoId()

Do not define such large functions in a header file.


More information about the webkit-reviews mailing list