[webkit-reviews] review granted: [Bug 45889] Style visibility: hidden on <br/> tags causes input fields to lose focus after deleting all content : [Attachment 81495] revised patch with respect to comments from Ryosuke Niwa

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Srikumar B <srikumar.b at gmail.com>'s
request for review:
Bug 45889: Style visibility: hidden on <br/> tags causes input fields to lose
focus after deleting all content
https://bugs.webkit.org/show_bug.cgi?id=45889

Attachment 81495: revised patch with respect to comments from Ryosuke Niwa
https://bugs.webkit.org/attachment.cgi?id=81495&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=81495&action=review

Thanks for fixing this bug!

> LayoutTests/editing/deleting/textfield-loose-focus-with-br.html:5
> +br{visibility:hidden}

Let's put spaces between words and semi-colon at the end as in br { visibility:
hidden; }

> LayoutTests/editing/deleting/textfield-loose-focus-with-br.html:11
> +<script>
> +if (window.layoutTestController) {
> +    layoutTestController.dumpAsText();
> +}
> +</script>

You should put this in the script element inside body so that you don't have to
have a separate script element.