[webkit-reviews] review requested: [Bug 53940] Implement the OES_vertex_array_object WebGL extension : [Attachment 81566] Implementation of OES_vertex_array_object for WebKit/OSX

[bugzilla-daemon at webkit.org]

Ben Vanik <ben.vanik at gmail.com> has asked  for review:
Bug 53940: Implement the OES_vertex_array_object WebGL extension
https://bugs.webkit.org/show_bug.cgi?id=53940

Attachment 81566: Implementation of OES_vertex_array_object for WebKit/OSX
https://bugs.webkit.org/attachment.cgi?id=81566&action=review

------- Additional Comments from Ben Vanik <ben.vanik at gmail.com>
>From the ChangeLog:

	Initial implementation of the OES_vertex_array_object extension adding
the OESVertexArrayObject
	extension container and WebGLVertexArrayObjectOES VAO object. The
extension is plumbed through
	the Extensions3D interface and implemented in the Extensions3DOpenGL
(WebKit/OSX) version when
	it is available.
	Two big changes touching code outside of the extension:
	* Moved the typedefs at the top of GraphicsContext3D.h to
GraphicsTypes3D.h (modeled after
	  GraphicsTypes.h). They are not namespaced as they weren't before.
	* To make the code cleaner/clearer all vertex attribute state has been
moved to the
	  WebGLVertexArrayObjectOES type (class VertexAttribState) except for
values which are still
	  on the WebGLRenderingContext. A default VAO is now used to store the
existing attribute
	  states for when no other VAO is used. Code in WebGLRenderingContext
dealing with buffers and
	  vertex attributes now defers to or stores values in the bound array
object.
	
	Tested against the WebGL conformance suite and the new
	oes-vertex-array-object test.