[webkit-reviews] review denied: [Bug 53897] [chromium] WebPageSerializerImpl doesn't serialize sub-frames correctly : [Attachment 81561] Fixed ChangeLog

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied public at fuzzac.com's request for
review:
Bug 53897: [chromium] WebPageSerializerImpl doesn't serialize sub-frames
correctly
https://bugs.webkit.org/show_bug.cgi?id=53897

Attachment 81561: Fixed ChangeLog
https://bugs.webkit.org/attachment.cgi?id=81561&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=81561&action=review

> Source/WebKit/chromium/src/WebFrameImpl.cpp:1963
> -WebFrameImpl* WebFrameImpl::fromFrameOwnerElement(Element* element)
> +WebFrameImpl* WebFrameImpl::fromFrameOwnerElement(const Element* element)

Why is this change related to the problem you're trying to solve?  We almost
never have "const Element*".

> Source/WebKit/chromium/src/WebPageSerializerImpl.cpp:331
> +			   String completeURL = subFrame ?
KURL(subFrame->url()) : param->document->completeURL(attrValue);

Why do we need to call KURL if we're trying to get a String in the end?