[webkit-reviews] review granted: [Bug 53838] nrwt multiprocessing: move code from dump_render_tree_thread to single_test_runner : [Attachment 81340] split out most of the code from drt into str

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 53838: nrwt multiprocessing: move code from dump_render_tree_thread to
single_test_runner
https://bugs.webkit.org/show_bug.cgi?id=53838

Attachment 81340: split out most of the code from drt into str
https://bugs.webkit.org/attachment.cgi?id=81340&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=81340&action=review

>
Tools/Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:3
1
> +"""This module implements a shared-memory, thread-based version of the
worker."""

Can you be more specific than "the worker"?

>
Tools/Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:2
02
> -	   tests_run_file =
self._port._filesystem.open_text_file_for_writing(tests_run_filename,
append=False)
> +							    "tests_run.txt")
> +	   tests_run_file =
self._port._filesystem.open_text_file_for_writing(tests_run_filename,
append=True)

Why did this change to append?