[webkit-reviews] review granted: [Bug 53942] [Chromium] Select popup box does not align with select button when appearance is not "menulist". : [Attachment 81550] Address tony's comments @3, 4

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted xiyuan <xiyuan at chromium.org>'s
request for review:
Bug 53942: [Chromium] Select popup box does not align with select button when
appearance is not "menulist".
https://bugs.webkit.org/show_bug.cgi?id=53942

Attachment 81550: Address tony's comments @3,4
https://bugs.webkit.org/attachment.cgi?id=81550&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=81550&action=review

> Source/WebCore/platform/chromium/PopupMenuChromium.cpp:1353
> +	   // Use kMinEndOfLinePadding when there is a scrollbar so that we use

> +	   // as much as (lineEndPaddingWidth - kMinEndOfLinePadding) padding
> +	   // space for scrollbar and allow user to use CSS padding to make the

> +	   // popup listbox align with the select element.
> +	   paddingWidth = paddingWidth - lineEndPaddingWidth +
kMinEndOfLinePadding;

This comment is much more useful.  Thanks!