[webkit-reviews] review denied: [Bug 53942] [Chromium] Select popup box does not align with select button when appearance is not "menulist". : [Attachment 81525] Fix typo in manual test name.

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has denied xiyuan <xiyuan at chromium.org>'s
request for review:
Bug 53942: [Chromium] Select popup box does not align with select button when
appearance is not "menulist".
https://bugs.webkit.org/show_bug.cgi?id=53942

Attachment 81525: Fix typo in manual test name.
https://bugs.webkit.org/attachment.cgi?id=81525&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=81525&action=review

just some small nits

> Source/WebCore/platform/chromium/PopupMenuChromium.cpp:1272
> +const int minEndOfLinePadding = 2;

static?  Also, should this be at the top of the file with the other constants? 
The other constants are named incorrectly (k prefix), but we can fix that
later.

> Source/WebCore/platform/chromium/PopupMenuChromium.cpp:1275
> +    bool rightAligned = m_popupClient->menuStyle().textDirection() == RTL;

Nit: rightAligned -> isRightAligned