[webkit-reviews] review denied: [Bug 53811] Null deref in DOMURL : [Attachment 81304] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 7 15:42:46 PST 2011


Jian Li <jianli at chromium.org> has denied Cris Neckar <cdn at chromium.org>'s
request for review:
Bug 53811: Null deref in DOMURL
https://bugs.webkit.org/show_bug.cgi?id=53811

Attachment 81304: Patch
https://bugs.webkit.org/attachment.cgi?id=81304&action=review

------- Additional Comments from Jian Li <jianli at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=81304&action=review

> Source/WebCore/ChangeLog:5
> +	   fix null deref in DOMURL

Please capitalize the 1st character.

> LayoutTests/ChangeLog:9
> +	   * fast/dom/domurl-script-execution-context-crash.html: Added.

Since DOMURL is only used for blob URL, I think we'd better put this new test
under fast/files.

> LayoutTests/fast/dom/domurl-script-execution-context-crash.html:6
> +	   e.apply(w,['webkitURL']);

Please add a space after comma.

> LayoutTests/fast/dom/domurl-script-execution-context-crash.html:16
> +    setTimeout(crash,30);

ditto.

> LayoutTests/fast/dom/domurl-script-execution-context-crash.html:26
> +e=(w=open()).eval;

Please add space before and after 2 "=" operators.


More information about the webkit-reviews mailing list