[webkit-reviews] review granted: [Bug 53853] Assertion failure in ~JSGlobalObject when loading apple.com HTML5 transitions demo page : [Attachment 81534] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Feb 7 15:19:43 PST 2011
Darin Adler <darin at apple.com> has granted Geoffrey Garen <ggaren at apple.com>'s
request for review:
Bug 53853: Assertion failure in ~JSGlobalObject when loading apple.com HTML5
transitions demo page
https://bugs.webkit.org/show_bug.cgi?id=53853
Attachment 81534: Patch
https://bugs.webkit.org/attachment.cgi?id=81534&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=81534&action=review
r=me, except I think you need to get the namespace stuff right so it doesn’t
break the GTK build
> Source/WebCore/html/HTMLCanvasElement.cpp:416
> + JSC::JSLock lock(SilenceAssertionsOnly);
If it’s JSC::JSLock, then it should also be JSC::SilenceAssertionsOnly, right?
More information about the webkit-reviews
mailing list