[webkit-reviews] review denied: [Bug 53916] [Qt] WebKit patches required to work with a modularized version of Qt : [Attachment 81475] Updated-include-paths-for-phonon

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 7 15:16:40 PST 2011


Eric Seidel <eric at webkit.org> has denied Kristian Amlie
<kristian.amlie at nokia.com>'s request for review:
Bug 53916: [Qt] WebKit patches required to work with a modularized version of
Qt
https://bugs.webkit.org/show_bug.cgi?id=53916

Attachment 81475: Updated-include-paths-for-phonon
https://bugs.webkit.org/attachment.cgi?id=81475&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=81475&action=review

> Source/WebCore/ChangeLog:10
> +	   No new tests. (OOPS!)

You'll need to remove thsi line (generally replacing it with explaination of
testing or why testing is impossible.  In this case you can just write
something like "build fix, no tests.")


More information about the webkit-reviews mailing list