[webkit-reviews] review denied: [Bug 53952] Add bundle API to get the background color of a frame : [Attachment 81537] Patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has denied Sam Weinig <sam at webkit.org>'s
request for review:
Bug 53952: Add bundle API to get the background color of a frame
https://bugs.webkit.org/show_bug.cgi?id=53952

Attachment 81537: Patch
https://bugs.webkit.org/attachment.cgi?id=81537&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=81537&action=review

> Source/WebKit2/WebProcess/WebPage/WebFrame.cpp:527
> +

All these early returns will cause the out parameters to be uninitialized. Can
m_coreFrame ever be null? 

Should we make getBodyBackgroundColor return whether it was successful or not?

> Source/WebKit2/WebProcess/WebPage/WebFrame.cpp:531
> +    *alpha = color.alpha();

We want the color components to be between 0 and 1, this doesn't do that.