[webkit-reviews] review denied: [Bug 53477] nrwt multiprocessing: add stubs for manager/worker : [Attachment 81307] update comments, rebase w/ latest 53158 patch

[bugzilla-daemon at webkit.org]

Mihai Parparita <mihaip at chromium.org> has denied Dirk Pranke
<dpranke at chromium.org>'s request for review:
Bug 53477: nrwt multiprocessing: add stubs for manager/worker
https://bugs.webkit.org/show_bug.cgi?id=53477

Attachment 81307: update comments, rebase w/ latest 53158 patch
https://bugs.webkit.org/attachment.cgi?id=81307&action=review

------- Additional Comments from Mihai Parparita <mihaip at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=81307&action=review

>
Tools/Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:38
> +eventually work as follows:

I'd really like to know what this says :)

>
Tools/Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:44
> +import Queue

Can you move this import into the no multiprocessing branch below?

>
Tools/Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:74
> +    by this method."""

Not sure I understand this comment. By "this method" you mean "the specified
worker model" (i.e. different models will have different sets of options)?

>
Tools/Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:91
> +	       the methods in message_broker2.ClientInterface.

s/ClientInterface/BrokerClient/