[webkit-reviews] review requested: [Bug 50969] <option> should support the dir attribute and be displayed accordingly both in the dropdown and after being chosen : [Attachment 81517] Patch for Chromium on Mac, v2

[bugzilla-daemon at webkit.org]

Avi Drissman <avi at drissman.com> has asked  for review:
Bug 50969: <option> should support the dir attribute and be displayed
accordingly both in the dropdown and after being chosen
https://bugs.webkit.org/show_bug.cgi?id=50969

Attachment 81517: Patch for Chromium on Mac, v2
https://bugs.webkit.org/attachment.cgi?id=81517&action=review

------- Additional Comments from Avi Drissman <avi at drissman.com>
Re directionalOverride, agreed; changed.

Re textDirection. This is of enum type, which IMO makes it clear.
platform/PopupMenuStyle.h has textDirection() returning the same enum.
"Direction" always means LTR/RTL when it comes to text. See
editing/WritingDirection.h, editing/EditingStyle.h's textDirection(),
WK/chromium/public/WebTextDirection.h, etc.