[webkit-reviews] review denied: [Bug 50969] <option> should support the dir attribute and be displayed accordingly both in the dropdown and after being chosen : [Attachment 81512] Patch for Chromium on Mac

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Avi Drissman
<avi at drissman.com>'s request for review:
Bug 50969: <option> should support the dir attribute and be displayed
accordingly both in the dropdown and after being chosen
https://bugs.webkit.org/show_bug.cgi?id=50969

Attachment 81512: Patch for Chromium on Mac
https://bugs.webkit.org/attachment.cgi?id=81512&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=81512&action=review

> Source/WebKit/chromium/public/WebMenuItemInfo.h:61
> +    bool directionalOverride;

it is not clear what directionalOverride means.  would it perhaps be
better named hasTextDirectionOverride as that is what WebCore seems
to be using for this field already?

if i'm the embedder, can i'm trying to render a menu based on this
information, what am i supposed to do with "directionalOverride" and
"textDirection"?  I think the other fields are fairly self-explanatory,
but these fields are not similarly obvious.